UCT/ROCM/IPC: Use correct agent for IPC copies #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix incorrect agent selection when all HSA agents are not visible to all ranks. Fix failure when unequal number of GPUs are assigned to different ranks.
|
Can one of the admins verify this patch? |
|
You probably want to add OSU copyright to the file |
|
Hi @shamisp I am working at AMD now. |
|
@souravzzz - congratulations !!! :) |
paklui
approved these changes
Nov 27, 2019
|
ok to test |
Mellanox CI: FAILED on 2 of 25 workers (click for details)Note: the logs will be deleted after 05-Dec-2019
|
Mellanox CI: PASSED on 25 workers (click for details)Note: the logs will be deleted after 05-Dec-2019
|
shamisp
approved these changes
Dec 4, 2019
|
@yosefe ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use local GPU agent as the source and destination for ROCM-IPC copies
Why